Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ruby example functional. #20

Closed

Conversation

jorge0136
Copy link

Fixes #18, allows ruby to actually say hello. I also agree with #19, it was bewildering to find that the docker image itself was the thing that was broken and not app engine.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@jorge0136
Copy link
Author

I signed it.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@jorge0136 jorge0136 changed the title Fixes ruby example to actual work. Make ruby example functional. May 8, 2019
@dazuma
Copy link
Member

dazuma commented May 20, 2019

We actually need to move this sample off the unsupported gcr.io/google-appengine/ruby base image, and instead use one of the official Ruby images from dockerhub.

@jorge0136 jorge0136 closed this Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ruby example fails to start.
3 participants